Night vision toggling #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2024
Merged
Merged
doublechest0
requested changes
Oct 22, 2024
Comment on lines
18
to
21
| [ViewVariables(VVAccess.ReadWrite), DataField("playSound"), AutoNetworkedField] | ||
| public bool PlaySound { get; set; } = true; // For dragon | ||
| [DataField("toggleOnSound")] | ||
| public SoundSpecifier ToggleOnSound = new SoundPathSpecifier("/Audio/Stories/Misc/night_vision.ogg"); |
There was a problem hiding this comment.
Suggested change
| [ViewVariables(VVAccess.ReadWrite), DataField("playSound"), AutoNetworkedField] | |
| public bool PlaySound { get; set; } = true; // For dragon | |
| [DataField("toggleOnSound")] | |
| public SoundSpecifier ToggleOnSound = new SoundPathSpecifier("/Audio/Stories/Misc/night_vision.ogg"); | |
| [DataField("toggleOnSound")] | |
| public SoundSpecifier? ToggleOnSound = new SoundPathSpecifier("/Audio/Stories/Misc/night_vision.ogg"); |
И проверку на null в коде, вместо еще одной переменной.
doublechest0
approved these changes
Oct 25, 2024
doublechest0
requested changes
Oct 25, 2024
А для дракона тогда как? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
О PR
Добавляет возможность переключения прибора ночного видения и очков ниндзя.
Почему / Баланс
Частично фиксит #49.
Тенеморфу добавлю аналогичное в #138
Нужно, чтобы дать ночное зрение дракону и карпам по итогам https://discord.com/channels/1111698541841240164/1297618376998387912
Медиа
Changelog
🆑 pheenty