Optimize memoization

Space48 · Dec 13, 2018 · 9a2d01f · 9a2d01f
1 parent 553a27c
commit 9a2d01f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/demo/auto/AutoValue_Address.php b/demo/auto/AutoValue_Address.php
@@ -108,10 +108,7 @@ public function foo()
 
  public function linesString(): string
  {
- if (!isset($this->__memoized['linesString'])) {
- $this->__memoized['linesString'] = parent::linesString();
- }
- return $this->__memoized['linesString'];
+ return $this->__memoized['linesString'] ?? ($this->__memoized['linesString'] = parent::linesString());
  }
 
  /**

diff --git a/src/Memoize/MemoizeMethodProcessor.php b/src/Memoize/MemoizeMethodProcessor.php
@@ -42,10 +42,7 @@ function (MethodDefinitionCollection $methodDefinitions, ReflectionMethod $metho
 THEPHP;
  } else {
  $methodBody = <<<THEPHP
- if (!isset(\$this->__memoized['$methodName'])) {
- \$this->__memoized['$methodName'] = parent::$methodName();
- }
- return \$this->__memoized['$methodName'];
+ return \$this->__memoized['$methodName'] ?? (\$this->__memoized['$methodName'] = parent::$methodName());
 THEPHP;
  }
  return $methodDefinitions->withAdditionalMethodDefinition(MethodDefinition::of($method, $methodBody));