Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD-3987: add config option TLSv13_Ciphersuites #749

Merged
merged 5 commits into from
Oct 26, 2023
Merged

SD-3987: add config option TLSv13_Ciphersuites #749

merged 5 commits into from
Oct 26, 2023

Conversation

juliebin
Copy link
Contributor

@juliebin juliebin commented Sep 20, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for support-docs ready!

Name Link
🔨 Latest commit 4f1d513
🔍 Latest deploy log https://app.netlify.com/sites/support-docs/deploys/6536cbc01bdc0600088eb47d
😎 Deploy Preview https://deploy-preview-749--support-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

content/momentum/4/config/tlsv13-ciphersuites.md Outdated Show resolved Hide resolved
content/momentum/4/config/tlsv13-ciphersuites.md Outdated Show resolved Hide resolved
content/momentum/4/config/tlsv13-ciphersuites.md Outdated Show resolved Hide resolved
content/momentum/4/config/index.md Show resolved Hide resolved
TLS_AES_128_CCM_8_SHA256
TLS_AES_128_CCM_SHA256
```
By default (if not explicitly specified through this configuration option), only the first three are enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "(if not explicitly specified through this configuration option)" seems redundant, especially since you state the default again below.

content/momentum/4/config/tls-protocols.md Outdated Show resolved Hide resolved
@kkelley1
Copy link
Contributor

kkelley1 commented Sep 20, 2023

Something could be added to content/docs/faq/supported-secure-cyphers.md as well.
Also, content/momentum/4/4-tls-macros.md.

@kkelley1
Copy link
Contributor

The tls_ciphers page could mention that this is only applicable for TLSv1.2 or below.

@deepakpn
Copy link
Contributor

Let's not merge this yet since we're not sure when we'll be releasing 4.6 yet.

Copy link
Contributor

@dkoerichbird dkoerichbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkoerichbird dkoerichbird merged commit 86d01a4 into main Oct 26, 2023
6 checks passed
@dkoerichbird dkoerichbird deleted the SD-3987 branch October 26, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants