fixed footer issue

[sauravrajleaf]

Issue

Fixes #75

Description

New content container add to Home & Bookmarked. Modified footer css.

Type of change

• Bug fix Css styling issue of footer.  #75 (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation change

Screenshot

Checklist:

• My code follows the style guidelines of this project
• The app runs properly
• I have performed a self-review of my own code
• I have formatted and commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[sauravrajleaf]

Please check if this can be merged.

[Sparsh1212]

@sauravrajleaf Please remove all the editor formatting changes like double quotes, semicolons, etc.
A quicker way to do them would be to revert all the current changes and turn auto-format on save off. Now do the correct changes in CSS and then push them to your PR.
After this you are free to turn it on again :)

[Sparsh1212]

Please remove the merge conflicts too.

[sauravrajleaf]

• As per the instructions, I have reverted all the changes done in all the files which was affected due to the code editor format on save. Later, I made changes to the required CSS.
• Also regarding the merge conflict it was occurring in Home.js file which was also changed by the editor on save option as per my knowledge. So, in my opinion reverting everything would have solved that too.

[sauravrajleaf]

Regarding the last part pushing them to my PR. I did not understand that very well.

• Should I make a new PR & close this one?
• Should I commit the changes to same PR?

If it's the later one, I have no idea to how to push changes to same PR. Can you please guide me through. Thanks.

[Sparsh1212]

• As per the instructions, I have reverted all the changes done in all the files which was affected due to the code editor format on save. Later, I made changes to the required CSS.
• Also regarding the merge conflict it was occurring in Home.js file which was also changed by the editor on save option as per my knowledge. So, in my opinion reverting everything would have solved that too.

Just a correction to your second point: The merge conflict is not due to the editor. It occurs when someone also proposed some changes on the same line of code that you were working and his/her changes got merged before you. That's why you faced a merged conflict. To resolve this, I'd suggest you to watch any tutorial on "How to resolve merge conflicts"

[Sparsh1212]

Regarding the last part pushing them to my PR. I did not understand that very well.

• Should I make a new PR & close this one?
• Should I commit the changes to same PR?

If it's the later one, I have no idea to how to push changes to same PR. Can you please guide me through. Thanks.

By pushing I meant, just do a new commit to your current PR and push those latest changes. By pushing, your newly added commits will also reflect here, and I will be able to see your updated code.

[sauravrajleaf]

I've done the changes. Please check once. I hope this time it's right.

[Sparsh1212]

The web view is working totally fine. However, in the mobile view the UI is breaking.
Here take a look:

Please make sure it is fine in the mobile view too.

Also please revert the changes made to package-lock.json as those also have been made automatically by your ide.