Change parameters of NoTypeDetectedException because of php deprecati… #4241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When exception is thrown with parameters as null, PHP deprecation messages are shown. I tried to change parameters to empty string and 0 for code - basically defaults. I think, that this could not break anything, but it would remove these deprecation messages.
1️⃣ Why should it be added? What are the benefits of this change?
No deprecation messages when exception is thrown. Messages are:
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.
3️⃣ Does it include tests, if possible?
No.
4️⃣ Any drawbacks? Possible breaking changes?
No.
5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌