-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use less transactions #1112
Merged
Merged
Use less transactions #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
Another blank line for Sphinx
dkfellows
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr is based on ideas from #1062
The purpose is to reduce the number of database transaction.
The basic idea is that all database patterns follow the pattern
with xyzDatabase() as db:
Most changes are just tabbing after the removal of the
with self.transaction() as cursor:
While NOT recommended it is possible to have two xyzDatabase Objects open on the same file
BUT if you write to both it goes BOOM!
see test_double_with
The pattern
with DsSqlliteDatabase() as db:
dsg = DataSpecificationGenerator(0, 1, 3, vertex, db)
looks strange in tests but was used so that
_GraphDataSpecificationWriter runs the whole generation in a single transaction
A few code changes includes:
Must be Done at the same time as:
SpiNNakerManchester/SpiNNMan#361
SpiNNakerManchester/sPyNNaker#1385