Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix power monitor buffer extraction #977

Merged
merged 10 commits into from
Sep 28, 2022
Merged

Fix power monitor buffer extraction #977

merged 10 commits into from
Sep 28, 2022

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Sep 21, 2022

The data extraction from ChipPowerMonitorMachineVertex had been disabled due to a bug.

This PR and the associated ....

  1. Add a new iterate_placements_by_vertex_type method
  2. rename the previous one to iterate_placements_by_xy_and_type
    (Both on Placements and the View)
  3. Use the new method where there either there is no Progressbar or where the ProgressBar did not make sense.
  4. Merge buffer_extractor into BufferManager.
  5. If using Java just use iterate_placements_by_vertex_type and avoid pre counting and storing
  6. If using python count and store until Remove many progress bars PACMAN#468 decides to keep or remove
  7. pre counter now uses iterate_placements_by_vertex_type as old version via AppVertex did not work as ChipPowerMonitorMachineVertex do not have app vertexes.

Must be done at the same time as:
SpiNNakerManchester/PACMAN#469

Tested by:
SpiNNakerManchester/IntegrationTests#142

Copy link
Contributor

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Christian-B Christian-B merged commit 6c157d6 into master Sep 28, 2022
@Christian-B Christian-B deleted the placement_by_type branch September 28, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is a fault with the code enhancement This adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants