-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2023
rowleya
approved these changes
Jul 28, 2023
This was referenced Jul 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #215
if this is approved close without merging the above
In Preparation for Spin2 this Introduces a set of Version classes defined by AbstractVersion
During sim.setup the version_factory() class will read the cfg and load a Specific Version class into the ....View.
The Version init will read any cfg setting that affect the values it returns so from this point only the Version is used to.
Machine changes included
Machine_factory lost ability to create boards from size (now Version) and from Chips (unused)
If the steps to check and repair Machine change for spin2 the rest should be moved to Version
Router init is always passed the n_available_multicast_entries
board width and height moved to spinn5_triad_geometry
width and height passed into SpiNNakerTriadGeometry
Any untitest that directly or indirectly created a Virtual Board now has to do:
set_config("Machine", "version", 5) Or set_config("Machine", "version", 3)
Must be done at the same time as:
SpiNNakerManchester/SpiNNMan#343
SpiNNakerManchester/PACMAN#520
SpiNNakerManchester/SpiNNFrontEndCommon#1093
SpiNNakerManchester/sPyNNaker#1373
Tested by:
SpiNNakerManchester/IntegrationTests#220
fixes: #211