Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version flexible Virtual Machine #256

Merged
merged 18 commits into from
Apr 19, 2024
Merged

Version flexible Virtual Machine #256

merged 18 commits into from
Apr 19, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Apr 9, 2024

Part of the Spin 2 preparations.

Make getting Virtual Machines more Flexible

  • Get a machine with a minimum of user cores
  • Get a machine with a minimum chips
  • Get a machine with a minimum boards
  • Get a machine with a minimum size

To do this:

  • The count of monitor (not scamp) cores moved to the Machine level
  • Added Version methods size_from_n_cores, size_from_n_chips and size_from_n_boards

The virtual_machine_generator also uses the values saved in the DataView

Removed as many hard coded version dependant values from tests as possible.

Includes:
SpiNNakerManchester/PACMAN#557
SpiNNakerManchester/SpiNNFrontEndCommon#1175
SpiNNakerManchester/sPyNNaker#1441
SpiNNakerManchester/SpiNNakerGraphFrontEnd#273

Tested by:
SpiNNakerManchester/IntegrationTests#266

@coveralls
Copy link

coveralls commented Apr 12, 2024

Coverage Status

coverage: 92.974% (+0.05%) from 92.928%
when pulling cdec110 on n_cores
into 00dfae5 on master.

@Christian-B
Copy link
Member Author

fixes #240

@rowleya rowleya merged commit 008acdc into master Apr 19, 2024
9 checks passed
@Christian-B Christian-B deleted the n_cores branch April 19, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants