Skip to content

Commit

Permalink
remove frame and cabinet properties
Browse files Browse the repository at this point in the history
  • Loading branch information
Christian-B committed Jul 31, 2023
1 parent b9d460b commit 7175f8a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 41 deletions.
24 changes: 1 addition & 23 deletions spinnman/connections/udp_packet_connections/bmp_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ class BMPConnection(UDPConnection, AbstractSCPConnection):
A BMP connection which supports queries to the BMP of a SpiNNaker machine.
"""
__slots__ = [
"_boards",
"_cabinet",
"_frame"]
"_boards"]

def __init__(self, connection_data):
"""
Expand All @@ -42,28 +40,8 @@ def __init__(self, connection_data):
else connection_data.port_num
super().__init__(
remote_host=connection_data.ip_address, remote_port=port)
self._cabinet = connection_data.cabinet
self._frame = connection_data.frame
self._boards = connection_data.boards

@property
def cabinet(self):
"""
The cabinet ID of the BMP.
:rtype: int
"""
return self._cabinet

@property
def frame(self):
"""
The frame ID of the BMP.
:rtype: int
"""
return self._frame

@property
def boards(self):
"""
Expand Down
18 changes: 0 additions & 18 deletions spinnman/model/bmp_connection_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,24 +28,6 @@ def __init__(self, ip_address, boards, port_num):
self._boards = boards
self._port_num = port_num

@property
def cabinet(self):
"""
The cabinet number.
:rtype: int
"""
return 0

@property
def frame(self):
"""
The frame number.
:rtype: int
"""
return 0

@property
def ip_address(self):
"""
Expand Down

0 comments on commit 7175f8a

Please sign in to comment.