Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version fix #353

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Version fix #353

merged 3 commits into from
Aug 3, 2023

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Aug 3, 2023

The test board spinn-4.cs.man.ac.uk was down which allowed some bugs to creep in.
This because the test where skipped

Before approving this PR please restart spinn-4.cs.man.ac.uk and rerun the tests

  1. BoardTestConfiguration changed from using a cfg file to a trial and error method
  • Will try a 4 Chip board first than spinn-4.cs.man.ac.uk and then 192.168.240.1
  • (minus) This will make the unit test take longer 45s instead of 19s if all three options are not pingable
  • (plus) Automatically uses three different options so more likely to run the tests rather than skipping
  • Can still be changed locally but by editing board_test_configuration.py rather than board_test_configuration.cfg
  1. BoardTestConfiguration now set cfg Machine/version so unittest_setup() needs to be called first

  2. Transceiver unittest use some private properties as they are testing/ using things not required by the normal runs.
    Alternatives are:

  3. Add api methods just for testing

  4. Remove the Tests

Depends on:
SpiNNakerManchester/SpiNNMachine#218
SpiNNakerManchester/SpiNNFrontEndCommon#1098
tested by:
SpiNNakerManchester/IntegrationTests#223

@Christian-B
Copy link
Member Author

blocker if spinn-4.cs.man.ac.uk is on

@rowleya rowleya merged commit 5713976 into master Aug 3, 2023
5 checks passed
@rowleya rowleya deleted the version_fix branch August 3, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants