protected Cpu info methods #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2023
rowleya
requested changes
Oct 3, 2023
spinnman/transceiver.py
Outdated
Comment on lines
1001
to
1008
| a = self.read_user(x, y, p, 0) | ||
| core_subsets = CoreSubsets() | ||
| core_subsets.add_processor(x, y, p) | ||
| process = GetCPUInfoProcess(self._scamp_connection_selector) | ||
| cpu_info = process.get_cpu_info(core_subsets) | ||
| b = cpu_info.get_cpu_info(x, y, p).user[0] | ||
| assert a == b | ||
| return a |
There was a problem hiding this comment.
Seems odd to go to the trouble of doing this twice!
There was a problem hiding this comment.
agree debug do it both ways. Removed
Merged
|
Replaced with #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks at the Transceiver functions
get_cpu_information_from_cores and get_cpu_infos
to see why these are called.
Turns out the usages where
So instead the methods that return detail CPUInfo objects have need protected and instead methods 1 to 3 have been added.
Methods 2 and 3 currently still return CPuInfo objects BUT only their iter method of this Object is used
This allows the Spin2 to do it differently if desired
Method 4 can actually be replicated by calling methods 2 or 3 using the x,y,p iter to a fill a set (or list) and then str that
There is a minor disadvantage that is rare cases
ChipProvenanceUpdater if it is going to call an Exception then it needs to make a few extra calls
Stand alone script get_cores_in_run_state also needs a few extra calls
Must be done at the same time as:
SpiNNakerManchester/SpiNNFrontEndCommon#1104
SpiNNakerManchester/sPyNNaker#1379
SpiNNakerManchester/SpiNNakerGraphFrontEnd#257
tested by:SpiNNakerManchester/IntegrationTests#230