Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a complex workflow on Support scripts. #271

Merged
merged 15 commits into from
May 22, 2024
Merged

Use a complex workflow on Support scripts. #271

merged 15 commits into from
May 22, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented May 22, 2024

Depends on:
https://github.com/SpiNNakerManchester/SupportScripts/blob/main/.github/workflows/python_checks.yml
(I was too lazy to do that in a PR)

Have one complex workflow which can easily be reused.

If the SupportScripts workflow is change all that may be needed is to change the branch protection rules.

  • As is the case here.

Based on:
SpiNNakerManchester/SpiNNMan#403

In the complex workflow does different things depending on the os and python version

  1. for none ubuntu os it only does tests and what is needed for tests
  • Current way other checks is ubuntu based
  • I don't want to have to fight mutiple rules if the disagree by os
  1. Most ubuntu also run flake8, pylint and mypy
  • each python tested once (except the one used to validate)
  • each ubuntu version tested once. latest used for remaining pythons
  • These are then run before the test steps in 1 to see errors earlier
  • One python version runs coverage
  1. One ubuntu/ python also validate runs rat, sphinx and cff-validator
  • this are run before the check steps in 2 and test steps 1 to see errors earlier

Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - always happy to reduce the amount of copy-paste done!

@Christian-B Christian-B merged commit 1a1f5c1 into master May 22, 2024
10 of 12 checks passed
@Christian-B Christian-B deleted the on_workflow branch May 22, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants