Add a with_library_path scope to Attachable #1380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's really really cool! Are you also looking at including a Markdown-editor (with preview?). Really like the folder syntax. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Not stale! how would House (MD) fit into this? |
|
House is not released yet, but I guess as trix alternative for the MD Parts it would work great. We'd need to expend it with an spina image picker though. This PR is only the preparation for that. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I'm working on markdown support for Spina. To show images from the library I want them to be included with this easy syntax:
within the markdown.Changes proposed in this pull request
This scope on Attachable helps to fetch the right images based on that syntax.
Guidance to review
Right now Spina doesn't use this scope internally. So I can see how this might not be accepted at the time. Also it's still using
ILIKEbecause that's what themainbranch does. Will change it once you merge the sql PR.