Fix date time range filter data extraction (#24)

SpiriitLabs · Jul 4, 2024 · 01b7864 · 01b7864
1 parent 880f58a
commit 01b7864
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/Event/Subscriber/AbstractDoctrineSubscriber.php b/Event/Subscriber/AbstractDoctrineSubscriber.php
@@ -147,7 +147,7 @@ public function filterDateTimeRange(GetFilterConditionEvent $event)
         $values = $event->getValues();
         $value = $values['value'];
 
-        if (isset($value['left_datetime'][0]) || $value['right_datetime'][0]) {
+        if (isset($value['left_datetime'][0]) || isset($value['right_datetime'][0])) {
             $event->setCondition($expr->datetimeInRange($event->getField(), $value['left_datetime'][0], $value['right_datetime'][0]));
         }
     }

diff --git a/Filter/DataExtractor/FormDataExtractor.php b/Filter/DataExtractor/FormDataExtractor.php
@@ -47,7 +47,7 @@ public function addMethod(DataExtractionMethodInterface $method)
     public function extractData(FormInterface $form, $methodName)
     {
         if (!isset($this->methods[$methodName])) {
-            throw new \RuntimeException(sprintf('Unknown extration method maned "%s".', $methodName));
+            throw new \RuntimeException(sprintf('Unknown extraction method maned "%s".', $methodName));
         }
 
         return $this->methods[$methodName]->extract($form);

diff --git a/Filter/DataExtractor/Method/ValueKeysExtractionMethod.php b/Filter/DataExtractor/Method/ValueKeysExtractionMethod.php
@@ -53,9 +53,6 @@ public function extract(FormInterface $form)
                         $values['value'][$key][$k] = $v;
                     }
                 }
-            } else {
-                dump($keys, $data);
-                throw new \InvalidArgumentException(sprintf('No value found for key "%s" in form data.', $key));
             }
         }