Deposit limit #52
Merged
Deposit limit #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # programs/tokenized_vault/src/instructions/deposit.rs # programs/tokenized_vault/src/instructions/withdraw.rs
TonioMacaronio
previously approved these changes
Dec 12, 2024
| @@ -48,6 +48,6 @@ pub struct Whitelist<'info> { | |||
|
|
|||
|
|
|||
| pub fn handle_whitelist(ctx: Context<Whitelist>, _user: Pubkey) -> Result<()> { | |||
| ctx.accounts.whitelisted.is_whitelisted = true; | |||
| ctx.accounts.user_data.whitelisted = true; | |||
| Ok(()) | |||
There was a problem hiding this comment.
I think it would be nice if a whitelist event gets emitted.
There was a problem hiding this comment.
Front-end engineers were asking how to check whether a user was whitelisted, I had to tell them a way to check whether a PDA initialized or not when there was whitelist PDa. Ideally it's good if the subgraph can provide such info.
There was a problem hiding this comment.
event was added, checking if PDA initialized won't work, cause now we have UserData PDA istead
|
|
||
| pub fn handle_revoke_whitelisting(_ctx: Context<RevokeWhitelisting>, _user: Pubkey) -> Result<()> { | ||
| pub fn handle_revoke_whitelisting(ctx: Context<RevokeWhitelisting>, _user: Pubkey) -> Result<()> { | ||
| ctx.accounts.user_data.whitelisted = false; |
There was a problem hiding this comment.
I think it would be nice of revoke whitelist event gets emitted
There was a problem hiding this comment.
event was added
codinghistorian
previously approved these changes
Dec 18, 2024
# Conflicts: # programs/tokenized_vault/src/instructions/deposit.rs # programs/tokenized_vault/src/instructions/direct_deposit.rs # programs/tokenized_vault/src/instructions/withdraw.rs
codinghistorian
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.