Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

27032023 - Aplico cambios del spunky toqueteado. #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ElCopado
Copy link

@ElCopado ElCopado commented Mar 28, 2023

Thank you for contributing a Pull Request!

Please follow the checklist:

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Search the issue tracker for similar pull requests
  • Check the code with flake8
  • If an enhancement pull request please create some documentation and at best an example
  • Make a descriptive pull request text (it will be used for the changelog)
  • Use Preview tab to see how your pull request will actually look like

What is the purpose of your pull request:

  • Bug fix
  • Improvement
  • New Feature
  • Documentation

Description:

Please make sure the description explains the purpose and effect of the pull request

Explanation of your pull request in arbitrary form goes here.

If you are fixing an existing issue, please include "Fixed #nn: <Summary>" in
your commit message and your description which explains what the change does.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 28, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.54%.

Quality metrics Before After Change
Complexity 498.73 ⛔ 532.38 ⛔ 33.65 👎
Method Length 159.03 😞 162.70 😞 3.67 👎
Working memory 100.31 ⛔ 103.95 ⛔ 3.64 👎
Quality 32.34% 😞 31.80% 😞 -0.54% 👎
Other metrics Before After Change
Lines 4028 4123 95
Changed files Quality Before Quality After Quality Change
spunky.py 32.34% 😞 31.80% 😞 -0.54% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spunky.py LogParser.handle_say 1403 ⛔ 14941 ⛔ 261 ⛔ 0.00% Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spunky.py LogParser.handle_kill 122 ⛔ 1047 ⛔ 27 ⛔ 1.45% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spunky.py LogParser.handle_awards 51 ⛔ 593 ⛔ 37 ⛔ 3.47% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spunky.py LogParser.find_game_start 42 ⛔ 412 ⛔ 24 ⛔ 8.38% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spunky.py LogParser.taskmanager 40 ⛔ 400 ⛔ 19 ⛔ 11.65% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant