Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dependency issues in CI #28

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: fix dependency issues in CI #28

merged 1 commit into from
Oct 3, 2023

Conversation

taeh98
Copy link
Contributor

@taeh98 taeh98 commented Oct 1, 2023

This is a work in progress, don't merge until the checks work properly.

@taeh98
Copy link
Contributor Author

taeh98 commented Oct 1, 2023

@Spydr06 You can't run a GitHub Actions job on Ubuntu 23; it isn't one of the available runners. Is there some way you can run your project on Ubuntu 22 by updating the dependencies (that are up-to-date in Ubuntu 23) yourself?

@Spydr06
Copy link
Owner

Spydr06 commented Oct 1, 2023

I don't think that's possible since Ubuntu isn't rolling-release

@taeh98
Copy link
Contributor Author

taeh98 commented Oct 1, 2023

I don't think that's possible since Ubuntu isn't rolling-release

Hmm ok, what do you have to do to run this project on your own computer? Do you have to install these dependencies yourself, assuming you haven't already done so for other stuff? Or are they only available as part of the distro?

@Spydr06
Copy link
Owner

Spydr06 commented Oct 1, 2023

Depends on the distro of course, but the -dev packages are normally not installed by default as they are only used for compilation. You'd have to do that yourself on a "real" Ubuntu machine too

@taeh98
Copy link
Contributor Author

taeh98 commented Oct 1, 2023

Depends on the distro of course, but the -dev packages are normally not installed by default as they are only used for compilation. You'd have to do that yourself on a "real" Ubuntu machine too

OK, so presumably if we do the same as you would to make this project work on a "real" Ubuntu 22 machine, it should work for the Ubuntu 22 runners too, no? What stuff would you have to install/update to make it work on the real machine?

@Spydr06
Copy link
Owner

Spydr06 commented Oct 1, 2023

On a real machine it probably won't work on ubuntu 22.04 and lower since the package is wayy outdated :(
I don't use Ubuntu for development so I never verified this.

@taeh98
Copy link
Contributor Author

taeh98 commented Oct 1, 2023

On a real machine it probably won't work on ubuntu 22.04 and lower since the package is wayy outdated :( I don't use Ubuntu for development so I never verified this.

@Spydr06 ah damn :/ So it's a library that comes packaged with Ubuntu that you can't upgrade? Which library/libraries?

@Spydr06
Copy link
Owner

Spydr06 commented Oct 1, 2023

seems like that, it's libadwaita, the ubuntu version is 1.1.7 but we need 1.2.0 or newer

@Spydr06
Copy link
Owner

Spydr06 commented Oct 1, 2023

I'm currently trying what it takes to download the .deb files manually and installing them

@Spydr06
Copy link
Owner

Spydr06 commented Oct 1, 2023

Great news @taeh98: Compiling libadwaita from source works on 22.04!!

  • Install these dependencies with apt: build-essential libcairo2-dev libgtk-4-dev meson valac sassc gettext git
  • Run these commands:
$ git clone https://gitlab.gnome.org/GNOME/libadwaita.git -b libadwaita-1-2 --depth=1
$ cd libadwaita
$ meson . _build -Dgtk_doc=false -Dtests=false -Dexamples=false
$ ninja -C _build install

(the last command must be run with root permissions)
Can you add this procedure as a new step in the CI process?

@taeh98
Copy link
Contributor Author

taeh98 commented Oct 1, 2023

Great news @taeh98: Compiling libadwaita from source works on 22.04!!

* Install these dependencies with `apt`: `build-essential` `libcairo2-dev` `libgtk-4-dev` `meson` `valac` `sassc` `gettext` `git`

* Run these commands:
$ git clone https://gitlab.gnome.org/GNOME/libadwaita.git -b libadwaita-1-2 --depth=1
$ cd libadwaita
$ meson . _build -Dgtk_doc=false -Dtests=false -Dexamples=false
$ ninja -C _build install

(the last command must be run with root permissions) Can you add this procedure as a new step in the CI process?

Oh, nice! I'll give it a go tomorrow and see if I can replicate it in the CI jobs :)

@Spydr06
Copy link
Owner

Spydr06 commented Oct 1, 2023

awesome, gl!

@taeh98
Copy link
Contributor Author

taeh98 commented Oct 2, 2023

Hey @Spydr06, does this look right? I might add some caching but if you think it's right then that should be it :)

@Spydr06
Copy link
Owner

Spydr06 commented Oct 2, 2023

Hey that's awesome, good job! (Yes caching seems like a good idea)

@taeh98 taeh98 force-pushed the fix-ci branch 5 times, most recently from ad04ebc to 7b9bbad Compare October 2, 2023 19:40
@taeh98
Copy link
Contributor Author

taeh98 commented Oct 2, 2023

Alright @Spydr06 I’ve finished, all the CI checks are now working :)

@taeh98 taeh98 changed the title WIP: fix: fix dependency issues in CI fix: fix dependency issues in CI Oct 2, 2023
@Spydr06
Copy link
Owner

Spydr06 commented Oct 3, 2023

Awesome, tysm!

@Spydr06 Spydr06 merged commit 45d4d09 into Spydr06:main Oct 3, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants