Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding artic version 1.5.8 #1134

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

adding artic version 1.5.8 #1134

wants to merge 1 commit into from

Conversation

erinyoung
Copy link
Contributor

There's a new version of artic!

Actually, there have been a few versions.

The usage has changed, so I've updated the base image version and the tests. I've also added in a new ENV variable.

Notable changes:
medaka and nanopolish support have been dropped. It's all Clair3 now.
medaka models are downloaded into the artic path
non-artic bedfiles and references are easier to use
artic-tools has been dropped

In short, any workflow using the 'latest' tag is going to fail.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung erinyoung marked this pull request as draft December 19, 2024 00:43
@erinyoung
Copy link
Contributor Author

Looks like there are tensorflow errors. I will address these and then take this PR out of draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant