Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding bakta version 1.10.3 and 1.10.3-light #1136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

erinyoung
Copy link
Contributor

There's a new version of bakta!

According to the release notes there have been a few bug fixes and some minor changes. The light database still appears to be version 1.5.

There are TWO Dockerfiles in this PR. It's so I don't forget one of them.

I copied the files from version 1.9.4, removed the DIAMOND install lines (because they aren't needed anymore) and updated the version arg.

$ diff bakta/1.9.4/Dockerfile bakta/1.10.3/Dockerfile 
1c1
< FROM mambaorg/micromamba:1.5.8 as app
---
> FROM mambaorg/micromamba:1.5.8 AS app
3,4c3
< ARG BAKTA_VER="1.9.4"
< ARG DIAMOND_VER="2.1.8"
---
> ARG BAKTA_VER="1.10.3"
25c24
< RUN micromamba install --name base -c conda-forge -c bioconda -c defaults bakta=${BAKTA_VER} diamond=${DIAMOND_VER} && \
---
> RUN micromamba install --name base -c conda-forge -c bioconda -c defaults bakta=${BAKTA_VER} && \
36c35
< FROM app as test
---
> FROM app AS test
$ diff bakta/1.9.4*light*/Dockerfile bakta/1.10.3*light*/Dockerfile 
1c1
< FROM mambaorg/micromamba:1.5.8 as app
---
> FROM mambaorg/micromamba:1.5.8 AS app
3,4c3
< ARG BAKTA_VER="1.9.4"
< ARG DIAMOND_VER="2.1.8"
---
> ARG BAKTA_VER="1.10.3"
27c26
< RUN micromamba install --name base -c conda-forge -c bioconda -c defaults bakta=${BAKTA_VER} diamond=${DIAMOND_VER} && \
---
> RUN micromamba install --name base -c conda-forge -c bioconda -c defaults bakta=${BAKTA_VER} && \
43c42
< FROM app as test
---
> FROM app AS test

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant