Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding busco version 5.8.2 and 2024-11-14 db #1142

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

erinyoung
Copy link
Contributor

There's a new version of busco and a new bacterial odb database!

According to the release notes there are some performance enhancements.

This PR contains TWO dockerfiles: one without the database, and one with. I've put them in the same PR so that I don't run into conflicts with the README.md while also not forgetting.

I checked the other dependencies, and only bbmap has had any updates.

Here the diffs between the two non-db files:

$ diff busco/5.8.0/Dockerfile busco/5.8.2/Dockerfile 
1c1
< ARG BUSCO_VER="5.8.0"
---
> ARG BUSCO_VER="5.8.2"
6c6
< ARG BBMAP_VER="39.10"
---
> ARG BBMAP_VER="39.13"

The full diff between the db-included files:


$ diff busco/5.8.0-*/Dockerfile busco/5.8.2-*/Dockerfile 
1c1
< ARG BUSCO_VER="5.8.0"
---
> ARG BUSCO_VER="5.8.2"
6c6
< ARG BBMAP_VER="39.10"
---
> ARG BBMAP_VER="39.13"

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung erinyoung changed the title adding busco version 5.8.2 and 2021-11-14 db adding busco version 5.8.2 and 2024-11-14 db Dec 23, 2024
[5.8.2-prok-bacteria_odb10_2024-11-14](./busco/5.8.0-prok-bacteria_odb10_2024-11-14/) 
->
 [5.8.2-prok-bacteria_odb10_2024-11-14](./busco/5.8.2-prok-bacteria_odb10_2024-11-14/)
@Kincekara Kincekara merged commit d4abf03 into StaPH-B:master Dec 23, 2024
3 checks passed
@Kincekara
Copy link
Collaborator

Thank you for the updates! Just fixed a typo on readme.
Here are the deploy links:
https://github.com/StaPH-B/docker-builds/actions/runs/12472211713
https://github.com/StaPH-B/docker-builds/actions/runs/12472224375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants