Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding dorado version 0.9.0 #1143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

erinyoung
Copy link
Contributor

There's a new version of dorado!

According to the release notes there are some new features and bug fixes.

I imagine the one everyone is most excited about is the "polish" feature.

I copied the files from the prior version, updated the version arg, and added a wordir.

The full diff:

$ diff dorado/0.8.3/Dockerfile dorado/0.9.0/Dockerfile 
4c4
< ARG DORADO_VER=0.8.3
---
> ARG DORADO_VER=0.9.0
40a41,42
> 
> WORKDIR /data

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing
    \

@erinyoung
Copy link
Contributor Author

I got this error from GA testing:

ERROR: failed to solve: failed to copy to tar: rpc error: code = Unknown desc = io: read/write on closed pipe
Error: buildx failed with: ERROR: failed to solve: failed to copy to tar: rpc error: code = Unknown desc = io: read/write on closed pipe

I haven't encountered this before and will need to do some searching to see how to fix this.

@Kincekara
Copy link
Collaborator

It may be a glitch in Git Hub.
Could you also try to use the cuda base image instead of devel. The last time I checked here, the cuda base could run dorado with GPU.

From https://hub.docker.com/r/nvidia/cuda

Overview of Images
Three flavors of images are provided:
base: Includes the CUDA runtime (cudart)
runtime: Builds on the base and includes the CUDA math libraries⁠, and NCCL⁠. A runtime image that also includes cuDNN⁠ is available.
devel: Builds on the runtime and includes headers, development tools for building CUDA images. These images are particularly useful for multi-stage builds.

@Kincekara
Copy link
Collaborator

I have just remembered GA doesn't have enough space to run this image. @kapsakcj tested and pushed the previous image manually as far as I remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants