Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added skani #758

Merged
merged 2 commits into from
Sep 26, 2023
Merged

added skani #758

merged 2 commits into from
Sep 26, 2023

Conversation

Kincekara
Copy link
Collaborator

Closes #747

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • [] If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara Kincekara marked this pull request as ready for review September 26, 2023 14:44
@erinyoung
Copy link
Contributor

Looks good.

Test works great

#13 [test 2/2] RUN skani dist e.coli-EC590.fasta e.coli-K12.fasta
#13 0.095 [00:00:00.000] (7fd3f5ef3800) INFO   skani dist e.coli-EC590.fasta e.coli-K12.fasta
#13 0.158 [00:00:00.063] (7fd3f5ef3800) INFO   Learned ANI mode detected. ANI may be adjusted according to a regression model trained on MAGs.
#13 0.158 [00:00:00.063] (7fd3f5ef3800) INFO   Generating sketch time: 0.063406564
#13 0.175 [00:00:00.080Ref_file	Query_file	ANI	Align_fraction_ref	Align_fraction_query	Ref_name	Query_name
#13 0.175 e.coli-K12.fasta	e.coli-EC590.fasta	99.39	91.89	92.46	NC_007779.1 Escherichia coli str. K-12 substr. W3110, complete sequence	NZ_CP016182.2 Escherichia coli strain EC590 chromosome, complete genome
#13 0.175 ] (7fd3f5ef3800) INFO   ANI calculation time: 0.01666564
#13 DONE 0.2s

@erinyoung
Copy link
Contributor

I added a hyperlink to the readme.md, which is going to re-trigger the github actions (GA).

Once that finishes, I'll

  • merge this PR
  • deploy to dockerhub and quay using skani
  • use the tags '0.2.0' as well as 'latest'

@erinyoung erinyoung merged commit fff8bc1 into StaPH-B:master Sep 26, 2023
2 checks passed
@erinyoung
Copy link
Contributor

You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/6315037174

@Kincekara
Copy link
Collaborator Author

Thanks!

@Kincekara Kincekara deleted the skani-0.2.0 branch September 26, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Container Request]: skani
2 participants