Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding GenoVi version 0.4.3 #785

Merged
merged 2 commits into from
Nov 15, 2023
Merged

adding GenoVi version 0.4.3 #785

merged 2 commits into from
Nov 15, 2023

Conversation

erinyoung
Copy link
Contributor

I find GenoVi really useful in quickly drawing cool figures of completed circular genomes.

GenoVi is really easy to use, but has circos as a dependency and isn't directly on conda (so it can be tricky to install).

The images it creates look like this:
genovi

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor Author

Closes #650

@Kincekara
Copy link
Collaborator

@erinyoung did you check the size of the image? pip installs nvidia-cuda libraries. I mean this image will be huge. I believe it happens because of the tensorboard requirement of deepnog. I am curious what happens if we try to remove cuda.

@erinyoung
Copy link
Contributor Author

deepnog is definitely required, and it lists tensorboard as a dependency.

Have you used deepnog without tensorboard?

I'm expecting the built image to be ~4.54GB in size.

@Kincekara
Copy link
Collaborator

No, I was just curious. I am merging this.

@Kincekara Kincekara merged commit 1e301c8 into master Nov 15, 2023
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for your PR!
You can follow its deployment progress from here: https://github.com/StaPH-B/docker-builds/actions/runs/6880864829

@erinyoung
Copy link
Contributor Author

Thank you!

@erinyoung erinyoung deleted the erin-genovi branch November 21, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants