-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated DNAAPLER and Mykrobe #787
Conversation
Changed dockerfile.version to 2 as well as ARG DNAAPLER_VER to 0.2.0
Updated Dockerfile
Updated to ver 0.12.2
Updated to include dnaapler 0.2.0
Updated to include correct genotyphi and new mykrobe
Included updated mykrobe and genotyphi versions.
These look great! Is there any reason why dnaapler is version 0.2.0 instead of 0.4.0, which is the latest version? Did you intend to have mykrobe be part of this PR or should I look for another PR? |
Hi Dr. Young! I upgraded to dnaapler 2.0 since that was the version defined in the request an update section. I just assumed I needed to add both mykrobe and dnaapler in the same request since they are both from the workshop. Sorry about that! |
Generally we have one Dockerfile per PR for reviewer simplicity, but it's not going to break anything. |
I updated the version of dnaapler to 0.4.0 and resolved some merge conflicts. Once the tests complete, I think these files are good to merge into main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!!!
I'm going to
- merge this PR
- push the new mykrobe image to dockerhub and quay using the 0.12.2 tag and overwrite the 'latest' tag
- push the new dnaapler image to dockerhub and quay using teh 0.4.0 tag and overwrite the 'latest' tag
Thank you, again, for your contribution!!! You can check the status of the mykrobe deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/6855078851 |
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)Updated main README.md for mykrobe and dnaapler for docker workshop. Updated both mykrobe and dnaapler to next version indicated by Dr. Young. Added README.md for both new versions.