Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to sanitize output for jinja templating #79

Merged
merged 8 commits into from
Apr 23, 2024

Conversation

cwilson21
Copy link
Contributor

What am I trying to do?
I am trying to sanitize output of jira, at all levels of any jinja templating things that would be markdown artifacts from getting jira data from the API so that it does not cause issues after you get it and try to use it as a var in a workflow due to those artifacts existing and causing stackstorm to think it is missing a variable.

I went for minimal touch instead of making it default, it is leaving it how it was unless you set it to true. Then it will iterate through all levels of the data to remove any of the jinja templating which from what I have found is mainly the {{ and }} .

@cwilson21 cwilson21 requested review from floatingstatic and a team as code owners April 23, 2024 06:02
@cwilson21 cwilson21 requested review from mickmcgrath13 and removed request for a team April 23, 2024 06:02
pack.yaml Outdated Show resolved Hide resolved
actions/get_issue.yaml Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
actions/get_issue.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@floatingstatic floatingstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@floatingstatic floatingstatic merged commit 0785da7 into StackStorm-Exchange:master Apr 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants