adopted: Track changed Image assets and use them to update image caches #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, since the bind groups do not get updated every frame, modified image assets would not be rebound. This caused hot reloading to no longer work. Similarly, the TextureArrayCache (when not using atlas) would not invalidate modified assets, so the textures would become out-of-date. Note there can be other reasons that an asset can be modified, so this should keep the assets more up-to-date in general.
Handles have some tie to lifetimes of assets. AssetIds don't!
ChristopherBiscardi
approved these changes
Aug 1, 2024
| .retain(|texture, _| texture_is_unmodified(texture)); | ||
| texture_cache.prepare_queue.retain(texture_is_unmodified); | ||
| texture_cache.queue_queue.retain(texture_is_unmodified); | ||
| texture_cache.bad_flag_queue.retain(texture_is_unmodified); |
There was a problem hiding this comment.
only strange thing I noticed was we don't seem to actually be using bad_flag_queue anywhere. What is this for?
There was a problem hiding this comment.
fascinating. I don't think it has ever been used. It seems to have originated here: 020d10e
ChristopherBiscardi
approved these changes
Aug 1, 2024
src/tiles/storage.rs
Outdated
| @@ -47,7 +47,7 @@ impl TileStorage { | |||
| /// Gets a tile entity for the given tile position, if: | |||
| /// 1) the tile position lies within the underlying tile map's extents *and* | |||
| /// 2) there is an entity associated with that tile position; | |||
| /// otherwise it returns `None`. | |||
| /// otherwise it returns `None`. | |||
There was a problem hiding this comment.
I think this is supposed to be a second paragraph, not a continuation of the second item
There was a problem hiding this comment.
Indeed, good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR text:
Fixes #430
Alternative to #431
Testing
I modified
tiles.pngand observed hot reloading occurring with:cargo run --example basic --features=bevy/file_watchercargo run --example basic --features=atlas --features=bevy/file_watcher