[Enhancement] Support recover FE metadata from backup meta #50966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjun-git
force-pushed
the
catch_exception_if_cannot_find_master
branch
from
90927f4
to
f113f34
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 7 / 13 (53.85%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
| @@ -160,8 +159,8 @@ public List<InetSocketAddress> getObserverNodes() { | |||
| for (ReplicationNode replicationNode : replicationGroup.getSecondaryNodes()) { | |||
| ret.add(replicationNode.getSocketAddress()); | |||
| } | |||
| } catch (UnknownMasterException e) { | |||
| LOG.warn("Catch UnknownMasterException when calling getObserverNodes.", e); | |||
| } catch (Throwable t) { | |||
| } catch (UnknownMasterException e) { | ||
| LOG.warn("Catch UnknownMasterException when calling getObserverNodes.", e); | ||
| } catch (Throwable t) { | ||
| LOG.warn("Catch Exception when calling getObserverNodes.", t); |
There was a problem hiding this comment.
Suggested change
| LOG.warn("Catch Exception when calling getObserverNodes.", t); | |
| LOG.warn("got exception when calling getObserverNodes.", t); |
| } catch (UnknownMasterException e) { | ||
| LOG.warn("Catch UnknownMasterException when calling getElectableNodes.", e); | ||
| } catch (Throwable t) { | ||
| LOG.warn("catch exception when calling getElectableNodes.", t); |
There was a problem hiding this comment.
Suggested change
| LOG.warn("catch exception when calling getElectableNodes.", t); | |
| LOG.warn("got exception when calling getElectableNodes.", t); |
|
replace by #51040 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
With this patch, it is possible to recover FE metadata if all machines are unavailable but the meta directory still exists.
bdbje_reset_election_group = truein fe.conf. We call this FE asFE_TMP.FE_NORMAL.FE_NORMALis added to cluster successfully. StopFE_TMP, and this node will be never used.bdbje_reset_election_group = trueto fe.conf, and restartFE_NORMAL.FE_NORMALand make sure the meta is normal.bdbje_reset_election_group = truefrom fe.conf, and restartFE_NORMAL.FE_NORMALand remove all the other FE nodes.What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: