Skip to content

Commit

Permalink
Merge pull request #1 from Stavrospanakakis/checks-gh-action
Browse files Browse the repository at this point in the history
Add GitHub Action for Pull Requests
  • Loading branch information
Stavrospanakakis committed Jun 25, 2023
2 parents e463cb3 + 8d45d0e commit 43e5608
Show file tree
Hide file tree
Showing 2 changed files with 81 additions and 2 deletions.
79 changes: 79 additions & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
name: "Checks"

on:
pull_request:

jobs:
check:
name: "Cargo check"
runs-on: "ubuntu-latest"
steps:
- name: "Check out the repo"
uses: actions/checkout@v3

- uses: "actions-rs/toolchain@v1"
with:
profile: "minimal"
toolchain: "stable"
override: true

- uses: "actions-rs/cargo@v1"
with:
command: "check"

test:
name: "Cargo test"
runs-on: "ubuntu-latest"
steps:
- name: "Check out the repo"
uses: actions/checkout@v3

- uses: "actions-rs/toolchain@v1"
with:
profile: "minimal"
toolchain: "stable"
override: true

- uses: "actions-rs/cargo@v1"
with:
command: "test"

fmt:
name: "Cargo format"
runs-on: "ubuntu-latest"
steps:
- name: "Check out the repo"
uses: actions/checkout@v3

- uses: "actions-rs/toolchain@v1"
with:
profile: "minimal"
toolchain: "stable"
override: true

- run: "rustup component add rustfmt"

- uses: "actions-rs/cargo@v1"
with:
command: "fmt"
args: "--all -- --check"

clippy:
name: "Cargo clippy"
runs-on: "ubuntu-latest"
steps:
- name: "Check out the repo"
uses: actions/checkout@v3

- uses: "actions-rs/toolchain@v1"
with:
profile: "minimal"
toolchain: "stable"
override: true

- run: "rustup component add clippy"

- uses: "actions-rs/cargo@v1"
with:
command: "clippy"
args: "-- -D warnings"
4 changes: 2 additions & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@ pub async fn run() -> Result<(), &'static str> {
timeout(my_duration, wait_for(args.addresses)).await
});

if let Err(_) = thread.join().unwrap().await {
if thread.join().unwrap().await.is_err() {
return Err("Connection timeout, could not connect to the addresses.");
}

Command::new(args.cmd[0].to_string())
Command::new(&args.cmd[0])
.args(&args.cmd[1..])
.spawn()
.expect("Failed to run the command.");
Expand Down

0 comments on commit 43e5608

Please sign in to comment.