Skip to content
This repository has been archived by the owner on Jun 6, 2022. It is now read-only.

since we're not linking anymore, update BPM pictures on manual pictur… #117

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kongomongo
Copy link
Contributor

…e selection. Also fixes BPM pictures on type 'other' (manually added to Steam)

@lolcatplays
Copy link

Hey could you send me a build with that fix? This has been nagging me for ages

SantaHey added a commit to SantaHey/steamgriddb-manager that referenced this pull request Apr 5, 2021
@SantaHey
Copy link
Contributor

SantaHey commented Apr 5, 2021

Hey could you send me a build with that fix? This has been nagging me for ages

@lolcatplays I adapt the code of @kongomongo and fix this issue in a new pull #135

I publish a built version with this fix and another if you want to install it
The link is available in this issue : #130

@lolcatplays
Copy link

Thank you SO much

@kongomongo
Copy link
Contributor Author

Hey could you send me a build with that fix? This has been nagging me for ages

@lolcatplays I adapt the code of @kongomongo and fix this issue in a new pull #135

I publish a built version with this fix and another if you want to install it
The link is available in this issue : #130

Strange, I never ran into that problem myself using master.

I use Steam/non-Steam, gog, etc... all without problems.

Can you show an example where the current master fails?

@SantaHey
Copy link
Contributor

SantaHey commented Apr 7, 2021

Can you show an example where the current master fails?

I downloaded the master and added this code in Steam.js/getNonSteamGames() at line 151
log.info("\n---Name : "+ item.appName);
log.info("appId from shortcuts.vdf: "+ item.appid);
log.info("appId with bitwise unsigned 32bit: "+ (item.appid >>> 0));
log.info("Generated OldAppId : "+ this.generateAppId(exe, appName));
log.info("Generated NewAppID : "+ this.generateNewAppId(exe, appName));

Result :
generateNewAppId() is the actual function used by SteamGridDB Manager and it's working only for games imported by SteamGridDB
image

If I set my image with SteamGridDB it doesn't update in Steam and if I set manually it generates a file with appid from shortcuts.vdf that isn't corresponding to generateNewAppId() result

@kongomongo
Copy link
Contributor Author

You are correct, generateNewAppId fails for manually added non-steam games. The question remains: why?

kongomongo pushed a commit to kongomongo/steamgriddb-manager that referenced this pull request May 1, 2021
kongomongo and others added 4 commits May 1, 2021 08:32
…e selection. Also fixes BPM pictures on type 'other' (manually added to Steam)
As I said here : SteamGridDB#130, SteamGridDB don't update assets for non-steam games added manually (non imported by SteamGridDB).

After researches I found that Steam generate an random individual ID for every non-steam game manually added and it doesn't correspond to the function generateNewAppId used here,

It results that SteamGridDB update images with the wrong ID's

My commit set the value of appid with generateNewAppID only if there's no existing appid so it works with imported and manually added non-steam games.
@SantaHey
Copy link
Contributor

SantaHey commented May 4, 2021

You are correct, generateNewAppId fails for manually added non-steam games. The question remains: why?

I think Steam generate a random id for every new non-steam game imported.

Example with the exact same executable, it generates each time a different.
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants