Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Payments 2.0 deep linking invoices #127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support Payments 2.0 deep linking invoices #127

wants to merge 3 commits into from

Conversation

valentino-sm
Copy link
Contributor

Payments 2.0 test implementation.

Don't use if you are not sure what you are doing.

@valentino-sm
Copy link
Contributor Author

related to #107

@Steffo99 Steffo99 linked an issue May 8, 2021 that may be closed by this pull request
Support Payments 2.0 (Invoice & Tips) #107
Open
@Steffo99
Copy link
Owner

Steffo99 commented May 8, 2021

What does this do, exactly? :)

I'll have a look when I can.

@Steffo99 Steffo99 added the feature A request for a new feature. label May 8, 2021
@Steffo99 Steffo99 self-requested a review May 8, 2021 14:06
@Steffo99 Steffo99 self-assigned this May 8, 2021
@Steffo99
Copy link
Owner

So... this adds fast/smart checkout from the Payments 2.0 API to greed, correct?

@valentino-sm
Copy link
Contributor Author

valentino-sm commented May 13, 2021 •
edited
Loading

Yes. The code is pretty clear so I didn't think for commenting.

Additional panel in admin menu for forwarding invoices letting people buy directly from forwarded invoice instantly. The code works perfectly as I have it in the prod =D
However it is not ready for merge as additional rework interface/localization and photo_url feature is needed.

@valentino-sm
Copy link
Contributor Author

valentino-sm commented May 13, 2021 •
edited
Loading

The problem with photo_url in API is it should be the url only. So in my local fork I did a hack with replacing all binary photo functions to url

@Steffo99
Copy link
Owner

Sorry if it's taking a while!

I'm currently busy with my university studies, and this PR looks like it needs a bit of testing to ensure it doesn't break anything...

@Steffo99 Steffo99 changed the title Payments2.0 Support Payments 2.0 deep linking invoices May 19, 2021
@valentino-sm
Copy link
Contributor Author

No apologies. It's up to you. Just trying help you with some ideas

@MoussLaTache
Copy link

Is it actually working ?
I want to implement payment 2.0 on my bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steffo99 Steffo99 Awaiting requested review from Steffo99

Assignees

@Steffo99 Steffo99

Labels
feature A request for a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Payments 2.0 (Invoice & Tips)
3 participants
@valentino-sm @Steffo99 @MoussLaTache