Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kuka210r3100 robot foxy #23

Open
wants to merge 5 commits into
base: foxy
Choose a base branch
from

Conversation

Robotgir
Copy link

No description provided.


<xacro:include filename="$(find kuka_kr210_support)/urdf/kr210r3100_macro.xacro"/>

<xacro:kuka_kr210r3100 prefix=""/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the prefix arg be used here?
<xacro:kuka_kr210r3100 prefix="$(arg prefix)"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<xacro:kuka_kr210r3100 prefix=""/>
<xacro:kuka_kr210r3100 prefix="$(arg prefix)"/>

@@ -121,6 +121,8 @@ ROS2 Distro | Branch | Build status | Documentation | Released packages
"kr150_2_macro.xacro",
"kr150r3100_2_macro.xacro",
"kr210l150_macro.xacro",
"kr210r3100_macro.xacro",
"lbr_iiwa_14_r820_macro.xacro",
Copy link

@muritane muritane Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this "lbr_iiwa_14_r820_macro.xacro" here? it is a little bit confusing as the pr name is only about adding kuka210r3100 (maybe it is just pedantic)

@@ -137,6 +139,8 @@ ROS2 Distro | Branch | Build status | Documentation | Released packages
"kuka_kr150_2",
"kuka_kr150r3100_2",
"kuka_kr210l150",
"kuka_kr210r3100",
"kuka_lbr_iiwa_14_r820",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@muritane
Copy link

muritane commented Mar 16, 2023

testing in rviz (docker foxy) works for me:
ros2 launch kuka_kr210_support test_kr210l150.launch.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants