Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chainable ffwd controllers #7

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Chainable ffwd controllers #7

wants to merge 1 commit into from

Conversation

mamueluth
Copy link
Member

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@mergify
Copy link

mergify bot commented May 8, 2023

This pull request is in conflict. Could you fix it @mamueluth?

@destogl @mamueluth
Make forward controller chainable.
72f5b76 
Enabling chanable mode for forward command controllers.

Fix all bugs in chained-controllers mode.

Remove debug output from forwarding controller.

Updated example ffwd chainable controller for new structure.
@mamueluth mamueluth force-pushed the chainable-ffwd-controllers branch from 6d960fe to 72f5b76 Compare May 8, 2023 08:50
@mergify Mergify
Copy link

mergify bot commented Nov 15, 2023

This pull request is in conflict. Could you fix it @mamueluth?

1 similar comment
@mergify Mergify
Copy link

mergify bot commented Feb 19, 2024

This pull request is in conflict. Could you fix it @mamueluth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamueluth @destogl