[PLT-1263] Add a cookie-csrf-per-request-limit attribute

Stratio · Nov 29, 2024 · a191eed · a191eed
1 parent 36bfc0a
commit a191eed
Showing 1 changed file with 26 additions and 25 deletions.
diff --git a/pkg/apis/options/cookie.go b/pkg/apis/options/cookie.go
@@ -8,18 +8,18 @@ import (
 
 // Cookie contains configuration options relating to Cookie configuration
 type Cookie struct {
-    Name                    string        `flag:"cookie-name" cfg:"cookie_name"`
-    Secret                  string        `flag:"cookie-secret" cfg:"cookie_secret"`
-    Domains                 []string      `flag:"cookie-domain" cfg:"cookie_domains"`
-    Path                    string        `flag:"cookie-path" cfg:"cookie_path"`
-    Expire                  time.Duration `flag:"cookie-expire" cfg:"cookie_expire"`
-    Refresh                 time.Duration `flag:"cookie-refresh" cfg:"cookie_refresh"`
-    Secure                  bool          `flag:"cookie-secure" cfg:"cookie_secure"`
-    HTTPOnly                bool          `flag:"cookie-httponly" cfg:"cookie_httponly"`
-    SameSite                string        `flag:"cookie-samesite" cfg:"cookie_samesite"`
-    CSRFPerRequest          bool          `flag:"cookie-csrf-per-request" cfg:"cookie_csrf_per_request"`
-    CSRFExpire              time.Duration `flag:"cookie-csrf-expire" cfg:"cookie_csrf_expire"`
-    CSRFPerRequestLimit     int           `flag:"cookie-csrf-per-request-limit" cfg:"cookie_csrf_per_request_limit"`
+    Name                string        `flag:"cookie-name" cfg:"cookie_name"`
+    Secret              string        `flag:"cookie-secret" cfg:"cookie_secret"`
+    Domains             []string      `flag:"cookie-domain" cfg:"cookie_domains"`
+    Path                string        `flag:"cookie-path" cfg:"cookie_path"`
+    Expire              time.Duration `flag:"cookie-expire" cfg:"cookie_expire"`
+    Refresh             time.Duration `flag:"cookie-refresh" cfg:"cookie_refresh"`
+    Secure              bool          `flag:"cookie-secure" cfg:"cookie_secure"`
+    HTTPOnly            bool          `flag:"cookie-httponly" cfg:"cookie_httponly"`
+    SameSite            string        `flag:"cookie-samesite" cfg:"cookie_samesite"`
+    CSRFPerRequest      bool          `flag:"cookie-csrf-per-request" cfg:"cookie_csrf_per_request"`
+    CSRFExpire          time.Duration `flag:"cookie-csrf-expire" cfg:"cookie_csrf_expire"`
+    CSRFPerRequestLimit int           `flag:"cookie-csrf-per-request-limit" cfg:"cookie_csrf_per_request_limit"`
 }
 
 func cookieFlagSet() *pflag.FlagSet {
@@ -36,23 +36,24 @@ func cookieFlagSet() *pflag.FlagSet {
     flagSet.String("cookie-samesite", "", "set SameSite cookie attribute (ie: \"lax\", \"strict\", \"none\", or \"\"). ")
     flagSet.Bool("cookie-csrf-per-request", false, "When this property is set to true, then the CSRF cookie name is built based on the state and varies per request. If property is set to false, then CSRF cookie has the same name for all requests.")
     flagSet.Duration("cookie-csrf-expire", time.Duration(15)*time.Minute, "expire timeframe for CSRF cookie")
-    flagSet.Int("cookie-csrf-per-request-limit", int(^uint(0)>>1), "default value for CSRFPerRequestLimit key")
+    flagSet.Int("cookie-csrf-per-request-limit", 0, "default value for CSRFPerRequestLimit key")
     return flagSet
 }
 
 // cookieDefaults creates a Cookie populating each field with its default value
 func cookieDefaults() Cookie {
     return Cookie{
-        Name:           "_oauth2_proxy",
-        Secret:         "",
-        Domains:        nil,
-        Path:           "/",
-        Expire:         time.Duration(168) * time.Hour,
-        Refresh:        time.Duration(0),
-        Secure:         true,
-        HTTPOnly:       true,
-        SameSite:       "",
-        CSRFPerRequest: false,
-        CSRFExpire:     time.Duration(15) * time.Minute,
+        Name:                "_oauth2_proxy",
+        Secret:              "",
+        Domains:             nil,
+        Path:                "/",
+        Expire:              time.Duration(168) * time.Hour,
+        Refresh:             time.Duration(0),
+        Secure:              true,
+        HTTPOnly:            true,
+        SameSite:            "",
+        CSRFPerRequest:      false,
+        CSRFExpire:          time.Duration(15) * time.Minute,
+        CSRFPerRequestLimit: 0,
     }
-}
+}