Tests/ci #16
Merged
Tests/ci #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raidzin
requested changes
Oct 15, 2023
| import os | ||
|
|
||
| from django.core.asgi import get_asgi_application | ||
|
|
||
| os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'adaptive_hockey_federation.settings') | ||
| os.environ.setdefault('DJANGO_SETTINGS_MODULE', |
There was a problem hiding this comment.
Мы проекте будем переносить строки другим способом
foo(
'bar',
'foo',
)Это относится ко всем подобным изменениям
pyproject.toml
Outdated
| @@ -9,6 +9,7 @@ readme = "README.md" | |||
| python = "^3.11" | |||
| django = "^4.2.6" | |||
| gunicorn = "^21.2.0" | |||
| django-stubs = "^4.2.4" | |||
There was a problem hiding this comment.
это зависимость тестовая, нужно перенести в группу test
Raidzin
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлены тесты flake8 и mypy
Для mypy использована библиотека django-stubs, внесены настройки в poetry
Поправлены все ошибки для полного прохождения github worklows