Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/base html #23

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Feature/base html #23

merged 4 commits into from
Oct 26, 2023

Conversation

Ariun2022
Copy link

шаблон получился не сильно похож на макет ((
я использовала offcanvas для боковой панели, кнопка вызова - расположена в footer
в header и footer количество и названия кнопок д.б. различны в зависимости от url, я пока поставила кнопки для страницы "Пользователи". Нужно ли прописывать все возможные вариации используя {% if view_name == 'main: ...' %} ? или можно как-то по-другому через context ??

Copy link
Member

@Raidzin Raidzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё хорошо, только нужно поправить footer

@@ -22,15 +13,17 @@
</head>
<body>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь нужно добавить классы d-flex flex-column min-vh-100 для корректной работы футера

{% endblock %}
{% block content %}
Основной текст
{% endblock %}
</main>
<footer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А здесь нужен класс mt-auto

@Raidzin Raidzin merged commit e3cfbe8 into dev Oct 26, 2023
1 of 2 checks passed
@Raidzin Raidzin deleted the feature/base_html branch October 26, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants