Доработан шаблон #25
Merged
Доработан шаблон #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raidzin
requested changes
Oct 30, 2023
| <a href="{{ url_name }}" | ||
| class="nav-link border border-white bg-cyan-300 hover:bg-violet-950 text-white p-2 w-44 text-left | ||
| {% if current_url_name == url_name %}bg-violet-950{% endif %}"> |
There was a problem hiding this comment.
Тут можно ещё улучшить и менять цвет текста кнопки, чтобы лучше читалось (кнопка тёмная цвет светлый и наоборот)
There was a problem hiding this comment.
оставила текст кнопки белым, т.к. на дизайн-проекте шрифт белый
| <button type="button" class="btn"> | ||
| <i class="bi bi-caret-right-fill fs-3" style="color: white;"></i> | ||
| </button> |
There was a problem hiding this comment.
Лучше наверное оставить одну кнопку т.к. вторая по сути бессмысленная (закрыть сайдбар можно только из сайдбара, а открыть только из футера)
| <div class="footer-copyright text-center py-3"> | ||
| <nav class="navbar navbar-light" style="background-color: #0dcaf0"> | ||
| <div class="container py-2"> | ||
| <div class="footer-copyright py-3"> |
There was a problem hiding this comment.
Тут стоит убрать py-3 и тогда футер будет до самого низа страницы
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Доработан базовый шаблон, визуально стало ,больше похоже на макет. + добавила изменение названий кнопок в header/footer в зависимости от url, и выделение кнопок цветом на боковой панели в зависимости от url