Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: #31

Merged
merged 3 commits into from
Nov 9, 2023
Merged

init: #31

merged 3 commits into from
Nov 9, 2023

Conversation

vovquewa
Copy link

@vovquewa vovquewa commented Nov 8, 2023

Улучшение CI тестироваания #29

  • Изменение в mypy_flake.yml и настройка CI из под poerty

- poetry CI
@vovquewa vovquewa requested a review from Raidzin November 8, 2023 14:39
poetry install

- name: flake8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше сделать тестирование mypy отдельно, иначе если проваливается тестирование flake8, то mypy даже не запускается

runs-on: ubuntu-latest
name: Проверка flake8
name: Статический анализ. Линтеры flake8 и mypy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Длинноватое название. Достаточо будет просто flake8 и mypy

@Raidzin Raidzin linked an issue Nov 8, 2023 that may be closed by this pull request
- разделение flake8 и mypy на отдельные jobы
- уточнение каталога поиска ошибок mypy
@Raidzin Raidzin merged commit d4b39b6 into dev Nov 9, 2023
0 of 4 checks passed
@Raidzin Raidzin deleted the feature/ci branch November 9, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Улучшение CI тестироваания
2 participants