Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Выделить из Header отдельную feature - SearchProduct #175

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

Segodnya
Copy link
Collaborator

No description provided.

@Segodnya Segodnya requested a review from aimenin December 27, 2023 09:58
@Segodnya Segodnya self-assigned this Dec 27, 2023
@Segodnya Segodnya added the refactoring реструктуризация и улучшение существующего кода label Dec 27, 2023
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Убрать query selector
Добавить story book

}

const closeContextMenuHandler = (e: Event) => {
const searchResultNode = document.querySelector(`.${styles.result}`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

через query selector мы в react ничего не делаем.
Только через ref

@Segodnya Segodnya requested a review from aimenin January 11, 2024 11:06
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Segodnya Segodnya merged commit 877b44b into master Jan 11, 2024
1 check passed
@Segodnya Segodnya deleted the refactor/search-product-feature-from-header branch January 11, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring реструктуризация и улучшение существующего кода
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Выделить из Header отдельную feature - SearchProduct
2 participants