Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#182-bug-fix-CartPage #184

Merged
merged 1 commit into from
Jan 19, 2024
Merged

#182-bug-fix-CartPage #184

merged 1 commit into from
Jan 19, 2024

Conversation

JuliaAvramenko
Copy link
Collaborator

Исправила ошибки, а также добавила Storybook к компонентам

@JuliaAvramenko JuliaAvramenko self-assigned this Jan 16, 2024
@JuliaAvramenko JuliaAvramenko added the bug Something isn't working label Jan 16, 2024
@aimenin aimenin self-requested a review January 17, 2024 09:02
@aimenin
Copy link
Collaborator

aimenin commented Jan 17, 2024

Ссылка на issue, без ссылки issue само не закроется

Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что то непонятное с ButtonDots

article={props.product.article}
className={styles.button_dots}
/>
<ButtonDots className={styles.button_dots} isMenuOpen={needToOpenContextMenuButtonDots}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я зашел в компонент ButtonDots и он не принимает children, не понимаю тогда констурукции

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

указала место в коде, где передаются children #184 (comment)

</ul>
</div>
)}
{isMenuOpened && <div ref={refContextMenu}>{children}</div>}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут мы прокидываем children, они прокидываются только если нужно открыть контекстное меню @aimenin

Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JuliaAvramenko JuliaAvramenko merged commit d8bfd0f into master Jan 19, 2024
1 check passed
@JuliaAvramenko JuliaAvramenko deleted the bug-182-on-CartPage branch January 19, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants