Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

поправить верстку subscribeForm #187

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

ArturKhelshtein
Copy link
Collaborator

  • компонент переделан по FSD → перенесен в features (сделано ранее, но задублировалось в entities)
  • проверено что с backEnd компоненет ничего не получает
  • моки не тронуты, т.к. нет данные с сервера не планируются к получению
  • поправлена верстка:
    -- при фокусе теперь не меняются размеры и не дергается компонент.
    -- заменил жесткие width на max-width
    -- сделал исчезновение плейсхолдера при фокусе

@ArturKhelshtein ArturKhelshtein added the refactoring реструктуризация и улучшение существующего кода label Jan 17, 2024
@ArturKhelshtein ArturKhelshtein linked an issue Jan 17, 2024 that may be closed by this pull request
3 tasks
@ArturKhelshtein ArturKhelshtein self-assigned this Jan 17, 2024
@aimenin aimenin self-requested a review January 18, 2024 08:45
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ArturKhelshtein ArturKhelshtein merged commit 53138d6 into master Jan 18, 2024
1 check passed
@ArturKhelshtein ArturKhelshtein deleted the refactoring-147-subscribeFormLayout branch January 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring реструктуризация и улучшение существующего кода
Projects
None yet
2 participants