Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement 163 header core api #227

Merged
merged 13 commits into from
Feb 7, 2024

Conversation

ArturKhelshtein
Copy link
Collaborator

сделано получение информации в footer с api по аналогии с header. также перенесен компонент footer из components в widgets

@ArturKhelshtein ArturKhelshtein added enhancement New feature or request refactoring реструктуризация и улучшение существующего кода api labels Feb 5, 2024
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне нравится!
Только по комментарию вопросы

import { fetchCategories } from '@/entities/Category/slice/categorySlice'
import SearchProduct from '@/features/SearchProduct'
import { linkItems } from '@/mockData/catalogListData'
// import { coreBaseData } from '@/mockData/coreBaseData'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужен комментарий?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

раньше данные получались из мок, теперь с сервера, можно и удалить в целом

@ArturKhelshtein ArturKhelshtein self-assigned this Feb 7, 2024
@ArturKhelshtein ArturKhelshtein merged commit 8a5e4a6 into master Feb 7, 2024
1 check passed
@ArturKhelshtein ArturKhelshtein deleted the enhancement-163-headerCoreApi branch February 7, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request refactoring реструктуризация и улучшение существующего кода
Projects
None yet
Development

Successfully merging this pull request may close these issues.

В компоненте footer внедрить api Переделка компонента header по fsd
3 participants