Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#210-api-inserted-to-StoriesBlock #228

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

JuliaAvramenko
Copy link
Collaborator

No description provided.

@JuliaAvramenko JuliaAvramenko self-assigned this Feb 5, 2024
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Парочка замечаний.
Плюс обрати внимание, что Артур добавил правила импортирования.
Смержи мейн себе в ветку и реши конфликты

src/entities/StoryCard/StoryCard.tsx Outdated Show resolved Hide resolved
src/entities/StoryCard/StoryCard.tsx Outdated Show resolved Hide resolved
@JuliaAvramenko JuliaAvramenko linked an issue Feb 10, 2024 that may be closed by this pull request
@JuliaAvramenko
Copy link
Collaborator Author

Исправила баги в компоненте и исправила некоторые баги по api в других помпонентах, которые я делала

@aimenin aimenin self-requested a review February 11, 2024 13:18
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Перед тем как смерджить - нужно исправить то, что советует github actions

@@ -1,6 +1,8 @@
@use '@/app/styles/index' as var;

.card {
max-width: 160px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В чем смысл одинаковой max-width и min-width, а не использования width?

src/entities/StoryCard/StoryCard.module.scss Outdated Show resolved Hide resolved
@aimenin
Copy link
Collaborator

aimenin commented Feb 25, 2024

@JuliaAvramenko Решаем конфликты и мержим pr

@JuliaAvramenko JuliaAvramenko merged commit 010e1ca into master Feb 28, 2024
1 check passed
@JuliaAvramenko JuliaAvramenko deleted the api-210-insert-to-StoriesBlock branch February 28, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Внедрить api в компонент StoriesBlock
2 participants