-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#211-product-card-in-fsd #232
#211-product-card-in-fsd #232
Conversation
В development ссылку на решаемый issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- В переделанных компонентах использовать типографику.
- В компоненте ProductLabels, насколько я понял, не прописан storybook
import { getStylesForCurrentLayout } from '../ProductCard/utils/utils' | ||
import styles from '../ProductCard/ProductCard.module.scss' | ||
import { getStylesForCurrentLayout } from '@/shared/ui/ProductLabels/utils/utils' | ||
// import styles from '../ProductCard/ProductCard.module.scss' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
нужен комментарий?
@@ -84,7 +84,8 @@ export const ProductsPage = () => { | |||
/> | |||
<section className={styles['content-products']}> | |||
{Array.from({ length: 8 }, (_, index) => ( | |||
<ProductCard key={index} layout={cardView} onEyeClick={changeModalState} /> | |||
// <ProductCard key={index} layout={cardView} onEyeClick={changeModalState} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
нужен комментарий?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нужно порешать конфликты в остальном можно мержить
Компонент товара из каталога был переведен по FSD