Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

категории под FSD #246

Merged
merged 2 commits into from
Mar 4, 2024
Merged

категории под FSD #246

merged 2 commits into from
Mar 4, 2024

Conversation

ArturKhelshtein
Copy link
Collaborator

@ArturKhelshtein ArturKhelshtein commented Feb 28, 2024 •
edited
Loading

компонент уже был по FSD

  • моки актуализировал в соответствии с запросом на сервер
  • убрал лишние данные из shared
  • актуализировал тип получаемых данных

@ArturKhelshtein ArturKhelshtein added enhancement New feature or request refactoring реструктуризация и улучшение существующего кода labels Feb 28, 2024
@ArturKhelshtein ArturKhelshtein self-assigned this Feb 28, 2024
@ArturKhelshtein ArturKhelshtein linked an issue Mar 3, 2024 that may be closed by this pull request
Переделка компонента Категории по fsd #143
Closed
3 tasks
aimenin
aimenin approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aimenin aimenin self-requested a review March 4, 2024 12:50
aimenin
aimenin reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вопросы по models

src/mockData/catalogListData.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А mockData разве не в shared -> model должна лежать?

src/models/CategoryModel.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

насколько я понимаю models - это тоже shared -> models

@ArturKhelshtein ArturKhelshtein merged commit 91e8f44 into master Mar 4, 2024
1 check passed
@ArturKhelshtein ArturKhelshtein deleted the enhancement-143-categoryGridToFSD branch March 4, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimenin aimenin aimenin approved these changes

Assignees

@ArturKhelshtein ArturKhelshtein

Labels
enhancement New feature or request refactoring реструктуризация и улучшение существующего кода
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Переделка компонента Категории по fsd
2 participants
@ArturKhelshtein @aimenin