Development 291 add to cart #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ь логику для кнопок добавления в корзину
…rontend into development_291_add-to-cart
…rontend into development_291_add-to-cart
…ки. Изменил настройки сборки в webpack, увеличил размер файлов в бандле, поскольку файлы в проекте большие и иначе не собирается.
… Чуть исправил стили для адаптивности верстки.
…rontend into development_291_add-to-cart
…rontend into development_291_add-to-cart
Merge branch 'master' of github.com:Studio-Yandex-Practicum/maxboom_frontend into development_291_add-to-cart
aimenin
requested changes
Apr 19, 2024
…rontend into development_291_add-to-cart
…rontend into development_291_add-to-cart
aimenin
requested changes
Apr 22, 2024
| const [showPopup, setShowPopup] = useState<boolean>(false) | ||
|
|
||
| const addThisToCart = () => { |
There was a problem hiding this comment.
гляди, ты вынес в хук useEffect, но так же повторяются функции addThisToCart и handleAddToCart, их тоже можно объявить в хуке и вернуть из него.
В кастомных хуках так же можно использовать useNavigate, useDispatch и тд.
src/widgets/Product/Product.tsx
Outdated
| const [showPopup, setShowPopup] = useState<boolean>(false) | ||
|
|
||
| const addThisToCart = () => { |
There was a problem hiding this comment.
тоже выносим функции по добавлению в корзину в хук
| @@ -24,6 +29,7 @@ type Props = { | |||
| slug: string | |||
| images: TImgList | |||
| quantity: number | |||
| id: number | |||
There was a problem hiding this comment.
если добавляешь новый пропс в типы, не забывай обновлять документацию у компонента
| const [isModalOpen, setIsModalOpen] = useState(false) | ||
| const [isModalClosing, setIsModalClosing] = useState(false) | ||
|
|
||
| const addThisToCart = () => { |
…rontend into development_291_add-to-cart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Подключил к кнопка добавления в корзину API и маршрутизацию на страницу корзины.
Немного подправил стили.