Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement_310_fix_routing_to_form_return_page #325

Merged

Conversation

AlexanderMorugin
Copy link
Collaborator

Задание - По клику на пункт возвраты переходить на форму с возвратами

Сделано:

  • Сделана страница формы возврата товара FormReturnPage.
  • Сделан роутинг. При клике на кнопку "Помощь" -> "Возвраты", в шапке сайта, переходим на страницу.
  • Отредактирован сам компонент FormReturn. Сделана валидация всех инпутов, включая радио кнопки.

@AlexanderMorugin AlexanderMorugin added the bug Something isn't working label Apr 19, 2024
@AlexanderMorugin AlexanderMorugin added this to the Помощь milestone Apr 19, 2024
@AlexanderMorugin AlexanderMorugin self-assigned this Apr 19, 2024
@AlexanderMorugin AlexanderMorugin linked an issue Apr 19, 2024 that may be closed by this pull request
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отличная работа!
Парочка замечаний, удали console.logs и мержи

validationSchema={validationSchema}
validateOnBlur={true}
onSubmit={(values, { setSubmitting, resetForm }) => {
console.log(JSON.stringify(values, null, 2))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

убираем console.log

className={styles.formReturn__button}
type="button">
type="button"
onClick={() => console.log('НАЗАД')}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

данный console.log нужен сейчас?
Если нужно что-то впоследствии доделать оставляем TODO, делаем issue и оставляем ссылку на issue рядом с TODO

@AlexanderMorugin AlexanderMorugin merged commit dc21d21 into master Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Роутинг на страницу возвраты
2 participants