Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#316-api-renew-product-amount #343

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

JuliaAvramenko
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Парочка замечаний, в остальном отлично.

<img src={product.images[0].image} alt={'product'} className={styles.image} />
)}
)) || <div></div>}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужен пустой div?
Я бы вернул <></> либо null

@@ -32,10 +33,13 @@ export type TCartEditProps = {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
export const CartEdit: React.FC<TCartEditProps> = ({ cartId, productList }: TCartEditProps) => {
const [needToOpenContextMenuButtonDots, setNeedToOpen] = useState(false)
const EMPTY = ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

константу выносим из компонента

@JuliaAvramenko JuliaAvramenko merged commit cdacfef into master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request
Projects
None yet
2 participants