Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#319-remove-product-from-cart #345

Merged
merged 3 commits into from
May 16, 2024

Conversation

JuliaAvramenko
Copy link
Collaborator

No description provided.

@JuliaAvramenko JuliaAvramenko requested a review from aimenin May 4, 2024 09:11
@JuliaAvramenko JuliaAvramenko self-assigned this May 4, 2024
@JuliaAvramenko JuliaAvramenko added enhancement New feature or request api labels May 4, 2024
@JuliaAvramenko JuliaAvramenko removed the request for review from aimenin May 6, 2024 07:09
@aimenin aimenin self-requested a review May 6, 2024 10:11
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Поправить селектор
  2. Вынести функцию
  3. Добавь, пожалуйста, блокировку кнопок увеличить, добавить и тд на время запроса. Чтобы мы жали на кнопку, например, уменьшить количество и в это время мы не могли нажать + или -, а иначе у нас может появится история, что один из запросов завалится и у нас будет что то не понятное на экране.

src/features/CartEdit/model/selectors.ts Outdated Show resolved Hide resolved
src/features/CartEdit/model/selectors.ts Show resolved Hide resolved
@aimenin aimenin self-requested a review May 13, 2024 15:52
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JuliaAvramenko JuliaAvramenko merged commit 68afeaa into master May 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

На странице корзины удалять товар из корзины
2 participants