Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

В компонент Scroll добавлен необязательный пропс, позволяющий скролит… #373

Merged
merged 3 commits into from
May 15, 2024

Conversation

kirill-k88
Copy link
Collaborator

…ь захватывая элемент. Компонент Наши клиенты о нас переделан на использование Scroll

…ь захватывая элемент. Компонент Наши клиенты о нас переделан на использование Scroll
Copy link
Collaborator

@aimenin aimenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отлично! Только одно замечание, давай его исправим и мержим


const handleMouseDown = (e: MouseEvent<HTMLDivElement, globalThis.MouseEvent>) => {
startX.current = e.clientX
if (listRef.current) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

на рефах проверяем еще сам реф на существование

Suggested change
if (listRef.current) {
if (listRef && listRef.current) {

@kirill-k88 kirill-k88 merged commit 562ece8 into master May 15, 2024
1 check passed
@kirill-k88 kirill-k88 deleted the enhancement_372_main_page branch May 15, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants